Rewrite front js in vanilla - Fix #121 #162
Conversation
|
This PR also adds a new behaviour : accordion items are now grouped by the fact that they are adjacent to each other, not just by being children of the same parent |
add alignment support - Fix philbuchanan#103 use hidden until-found - Fix philbuchanan#161 Remove the use of children - Maybe Fix philbuchanan#117 add resize event dispatch - Fix philbuchanan#59 revert removal of the button option use <accordion-item> custom element add js documentation requestIdleCallback before window scroll remove use of "window."
|
Fixing #29 could be has simple has : document.querySelectorAll('accordion-item').forEach(i => i.open({noChecksAndScroll: true, noAnim: true}))I don't know how we could go about adding a button though (maybe another block ?) |
|
Changed the allowedFormats handling : only disallow core/link to allow other formats (adds the ability to add inline images, colors, etc. and most importantly every other plugin defined formats) Fix: #173
|
|
@philbuchanan hi ! Are you still maintaining this repo ? |
|
I am maintaining this plugin for my own purposes, but am not actively developing it any more. I just don't have the time and financially it doesn't make sense for me to devote more time to it. This particular PR is too far reaching for me to fully test and merge into the main plugin. I like the idea of removing the jQuery dependency, but this PR does far more than that. I would suggest forking the plugin and making changes to suit your needs. |
corentin-gautier
force-pushed
the
master
branch
from
c378401
to
3b49840
Compare
Hi @philbuchanan !
Thanks for this plugin ! I've been using it on a couple of projects already, however the dependency to jquery is kind of a deal breaker ... so I took the liberty to rewrite the js into vanilla !
I hope you'll be able to test this and merge if everything's ok 🎉
Rewrite front js in vanilla - Fix #121
add alignment support - Fix #103
accordion-blocks.min.js is now 1.8kB instead of 1.3kB (gzipped) but this removes ~37kB of jquery dependencies 🎉 .
EDIT :