Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seach engine Shortcuts do not work, "occasionally" #1449

Closed
esster opened this issue Jan 29, 2015 · 9 comments
Closed

Seach engine Shortcuts do not work, "occasionally" #1449

esster opened this issue Jan 29, 2015 · 9 comments

Comments

@esster
Copy link

esster commented Jan 29, 2015

I have 3 vbar search engine shortcuts:

w:
i:
a:

w and i work, as expected, "a" does not, for no recognizable reason.

I, of course, "naively" assumed that the vbar checks the shortcut list first
before doing anything else, but this does not seem to be the case ...
#1397

@smblott-github
Copy link
Collaborator

Might this be a symptom of #1384?

Could you post exactly what you have for a, please?

@esster
Copy link
Author

esster commented Jan 29, 2015

in "reality" it presently looks like this:

a: http://dict.leo.org/frde/index_de.html#/search=%s
b: http://dict.leo.org/ende/index_de.html#/search=%s

and b does not work,

this works:

dxf: https://www.google.com/search?q=define+%s

but I had to try out a dozen different shortcuts before I finally
found one that worked ...

...

@esster esster closed this as completed Jan 29, 2015
@esster esster reopened this Jan 29, 2015
@esster
Copy link
Author

esster commented Jan 29, 2015

Closed by accident!

@smblott-github
Copy link
Collaborator

I tried...

b: http://dict.leo.org/ende/index_de.html#/search=%s

... and it seemed fine:

  • o, a something, Enter.

What are you seeing?

@nebenjamin
Copy link

I believe I may be experiencing a similar issue. I have the following search engine defined:
mdn: https://developer.mozilla.org/en-US/search?q=%s

When I attempt to use the CSE, I would expect to run into #1384, which is what happens if I use the provided Wikipedia CSE. Instead, my search gets sent to my default search engine. So entering mdn array.slice in the Vomnibar results in being directed to https://duckduckgo.com/?q=mdn%20array.slice.

@mrmr1993
Copy link
Contributor

Using which version, master or Chrome Web Store?

@nebenjamin
Copy link

Chrome Web Store.

Chrome Version: 41.0.2272.101 m
Vimium Version: 1.49

@smblott-github
Copy link
Collaborator

@nebenjamin. This is odd. Unfortunately, I can't seem to reproduce it in either 1.49 or master....

@nebenjamin
Copy link

I added Chrome and Vimium to a Linux VM and couldn't reproduce it either. I did go ahead and debug what I've got installed rather than installing Node.js, npm and coffeescript. Looking at the compiled javascript, the debugger was showing me an object that looks like this:

{
  mdn: https://developer.mozilla.org/en-US/search?q=%s,
  w: "http://www.wikipedia.org/w/index.php?title=Special:Search&search=%s"
}

I changed my CSE to:
mdn: 'https://developer.mozilla.org/en-US/search?q=%s'

Then I saved my settings which then results in behavior like #1384. I then removed the single-quotes and the CSE works without #1384 behavior.

It seems like master may fix the issue since parseSearchEngines appears to have been modified since 1.49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants