[Firefox] Vimium shortcuts don't work after Ctrl-Enter in Gitlab diff viewer

[inducer]

Using vimium 1.59.9, add a comment in the Gitlab diff viewer, e.g. here:

https://gitlab.com/inducer/comment-dumpster/commit/7a90f4b74f70afa6d83bcfc5214c600a6d50b208

To do so, log in and click on the little speech bubble to the left of a line in a diff. (I've created that project to demonstrate this issue, so feel free to litter it up with comments.)

Hit Ctrl-Enter to submit your diff comment. Notice that none of the vimium shortcuts work any more.

[smblott-github]

I don't want to add a spurious comment to your example page just to check, but perhaps it is similar to here on Github, where an input remains focused after a comment is submitted.

Does <Escape> solve the problem.

[inducer]

It doesn't, as far as I can tell.

[lydell]

perhaps it is similar to here on Github, where an input remains focused after a comment is submitted

(As a side note, I actually emailed Github about this keyboard accessibility problem once and got a response that they would take a look at it, but nothing has happened ;) )

[smblott-github]

BTW... I run my own instance of Gitlab and cannot reproduce this issue there.

[mrmr1993]

If memory serves, I suspect this is another manifestation of the Firefox focus bug: an element which is focused and becomes unfocusable doesn't get blurred. This causes a few problems:

• If the element can no longer receive key* events (eg. it's display: none), the events aren't fired anywhere in the DOM, and we correspondingly can't catch them.
  • this is a showstopper, and a possible cause of this.
• The element doesn't ever dispatch its own blur events, and doesn't blur on calls to .blur()
  • this neuters our blurring for insert mode, but mostly doesn't matter because we never get the event (1st bullet).

I can't find the FF issue at the moment, I'll look again later.

[eejdoowad]

I fixed this bug in Saka Key by checking document.activeElement on every keydown event in text mode. Maybe you could try something similar?

https://github.com/lusakasa/saka-key/blob/master/src/modes/text/client.js#L10

(Returning 'Reset' will cause the document.activeElement to be checked. If it is a text input, stay in text mode. If not, switch to command mode)

[lydell]

VimFx also seems to work around this missing blur event: https://github.com/akhodakivskiy/VimFx/blob/376486f4dc61d75add1c26263d1f4baf39d3abd4/extension/lib/events-frame.coffee#L302-L311

[wshanks]

@inducer Have you tried with the focus stealing preference on/off? See also #2613

[inducer]

I assume you mean "Don't let pages steal the focus on load". If so, no, that makes no difference either way.