Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have the default be to restart Valet if it is installed? #38

Open
simensen opened this issue Dec 11, 2017 · 1 comment
Open

Can we have the default be to restart Valet if it is installed? #38

simensen opened this issue Dec 11, 2017 · 1 comment

Comments

@simensen
Copy link

Trying this project out today to see if it will work for me switching between PHP versions. However, I use Valet and find that I need to specify -c=valet to make sure Valet is restarted.

Is there a reason for this? If not, if I provided a way to either make restarting Valet happen by default or by some other means (env config values, etc) would that be accepted?

@tiretdusix
Copy link

Hello @simensen.

On the contrary i use neither apache and valet and find that having to add flags for excluding stuff i don't use is cumbersome. Flags for other optional programs should be inclusive instead of exclusive imho.

I agree that the fact i have to explicitly "--skip" valet while you have to explicitly switch "--config" for it, sounds kind of counter intuitive.

Maybe what one could do is detects if commands for valet, apache, ... and such exists and restart those services automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants