Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switcher to support PHP 7.3 #54

Merged
merged 3 commits into from
Dec 8, 2018

Conversation

chrisdeeming
Copy link
Contributor

PHP 7.3 was released yesterday and the relevant brew formulas were made available today so a quick merging of these changes to support php@7.3 would be greatly appreciated @philcook 馃檪

PHP 7.3 was released yesterday and the relevant brew formulas were made available today so a quick merging of these changes to support php@7.3 would be greatly appreciated @philcook 馃檪
@ikari7789
Copy link
Collaborator

The script itself and the Travis scripts need updated as well to add 7.3

@chrisdeeming
Copy link
Contributor Author

That's already been done, or did I miss something?

https://github.com/philcook/brew-php-switcher/pull/54/files

Copy link
Collaborator

@ikari7789 ikari7789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! Viewed on mobile and it only showed me the readme updates before.

@ikari7789
Copy link
Collaborator

I unfortunately can鈥檛 tag this as a release, but I can merge it so you can at least install HEAD.

@ikari7789 ikari7789 merged commit 99532fc into philcook:master Dec 8, 2018
@chrisdeeming
Copy link
Contributor Author

No rush on my side as I've just updated my script locally but thank you very much @ikari7789 馃憤

@chrisdeeming chrisdeeming deleted the patch-1 branch December 8, 2018 00:02
@ikari7789
Copy link
Collaborator

Looks like they already removed PHP 7.0 as well. Not sure if it should be removed immediately from this script or not considering there鈥檚 probably still people using it.

@chrisdeeming
Copy link
Contributor Author

I'm actually very surprised they've taken that approach. I've asked them to reconsider:

Homebrew/homebrew-core#34739 (comment)

@ikari7789
Copy link
Collaborator

I had to argue to get them to include 7.0 initially when they switched to the new system and removed the old tap. They had only wanted to include the versions under active development and had only left 5.6 because it was an old major version.

@chrisdeeming
Copy link
Contributor Author

Indeed. Arguably 5.6 is even more important due to that. By their criteria there, 5.6 will be removed in 22 days when it becomes EOL at the end of this month too, which will be a shame.

@cfont
Copy link

cfont commented Dec 10, 2018

so, what needs to happen for this update to trickle all the way down to us "normal" end users of homebrew and get the update? I know I grab this HEAD and have done that for other projects but it is so much nicer when we can just brew update && brew upgrade and be done with it.

@ikari7789
Copy link
Collaborator

@cfont We'd need @philcook to tag a new version.

@cfont cfont mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants