-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update switcher to support PHP 7.3 #54
Conversation
PHP 7.3 was released yesterday and the relevant brew formulas were made available today so a quick merging of these changes to support php@7.3 would be greatly appreciated @philcook 馃檪
The script itself and the Travis scripts need updated as well to add 7.3 |
That's already been done, or did I miss something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! Viewed on mobile and it only showed me the readme updates before.
I unfortunately can鈥檛 tag this as a release, but I can merge it so you can at least install HEAD. |
No rush on my side as I've just updated my script locally but thank you very much @ikari7789 馃憤 |
Looks like they already removed PHP 7.0 as well. Not sure if it should be removed immediately from this script or not considering there鈥檚 probably still people using it. |
I'm actually very surprised they've taken that approach. I've asked them to reconsider: |
I had to argue to get them to include 7.0 initially when they switched to the new system and removed the old tap. They had only wanted to include the versions under active development and had only left 5.6 because it was an old major version. |
Indeed. Arguably 5.6 is even more important due to that. By their criteria there, 5.6 will be removed in 22 days when it becomes EOL at the end of this month too, which will be a shame. |
so, what needs to happen for this update to trickle all the way down to us "normal" end users of homebrew and get the update? I know I grab this HEAD and have done that for other projects but it is so much nicer when we can just |
PHP 7.3 was released yesterday and the relevant brew formulas were made available today so a quick merging of these changes to support php@7.3 would be greatly appreciated @philcook 馃檪