Add initial support for php70 #7 #9
Conversation
| @@ -21,7 +21,7 @@ Your Apache config must be setup using the same paths as below. Replace homebrew | |||
| Version | |||
| ---- | |||
|
|
|||
| 1.4 | |||
| 1.5 | |||
There was a problem hiding this comment.
I though you'd like to release the new version if that PR comes through.
|
Any news on if this is likely to be merged? |
|
@akrabat apologise I have been away on holiday and not been able to review this. I will take a look this week. |
|
Thanks @philcook :) |
| @@ -68,9 +74,14 @@ then | |||
| echo "Switching your apache conf" | |||
| for j in ${php_installed_array[@]} | |||
| do | |||
| sudo sed -i.bak "s/^LoadModule[ \t]php5_module[ \t]$php_opt_path$j$apache_php_lib_path/\#LoadModule php5_module $php_opt_path$j$apache_php_lib_path/g" $apache_conf_path | |||
There was a problem hiding this comment.
@mirfilip this part is required to comment out all existing PHP modules in apache conf not just the one being selected.
|
@mirfilip checked out your code and unfortunately it doesnt quite work due to the fact it doesnt comment out any other PHP module lines in the apache code. However I have done some work myself and put it in a php7 branch. This version has a few advantages as well that I have been meaning to put in. Mainly that if the PHP module apache conf line its already in the apache conf it will now add it for you. I will merge mine into master shortly but in the meantime if you want to checkout this branch your more than welcome to. |
Hi,
just a quick take on mentioned task. Please review it, it has been ages since I have done any scripting in bash.
Two things to mention:
php7x. Even though it's still beta, I went on with current conversion and didn't do anything like70bor similar.httpd.confgot changed, I needed some conditional logic.Also, I noticed there is something broken with substitution of
LoadModule php5_module ...inhttpd.confin HEAD. It's not related to my changes. I didn't change any logic except naming, but I will revisit the matter later.