Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in packages not caught by remix app / turbo resulting in non updated ui #43

Closed
Jarrodsz opened this issue Jun 2, 2023 · 2 comments

Comments

@Jarrodsz
Copy link

Jarrodsz commented Jun 2, 2023

Porting all my code to the mono repro I found out a "bug/issue" that is inconvenient at the most.

Say you have an remix app remix-app and import a package named @gospel/ui, and inside this package there is a /src/Component with an error. This error will not appear when running the application like

pnpm run --filter remix-app dev

If however one do a build in the packages/ui and run pnpm build then the error appears.
It caught my attention because i had multiple times i ported components over had some issues with them and my remix app ui would not show any of my components I updated correctly. It will show in the terminal that watchdog saw a modification but those modifications never appear because of in the package there is some error which is a bit confusing and misleading.

Would there be a way around this inconvenient behaviour?

@Jarrodsz
Copy link
Author

Jarrodsz commented Jun 2, 2023

For example I get this message

💿 File changed: ../../packages/site/src/components/Hero.tsx

But then still in my remix app the changes are not reflected.
I think it worked before now somehow broken again :/

Even though I can run a pnpm build on the package in packages/site/ with no errors.

It seems after I do a

pnpm build
pnpm run --filter remix-app dev

I see the changes but only when I run the build command before.

@Jarrodsz
Copy link
Author

Jarrodsz commented Jun 2, 2023

EDIT:

Ok i Finally figured out why it breaks.
The tailwind style.css watch / build command in the dev task of the package seems to cause this issue since Im not using tailwind it tries breaks the ui package dev command after removing the tailwind specifics it seems to update my components in realtime

@Jarrodsz Jarrodsz closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant