Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove unloader associated to windows when they unload #1

Closed
erikvold opened this issue Jun 13, 2011 · 3 comments
Closed

Need to remove unloader associated to windows when they unload #1

erikvold opened this issue Jun 13, 2011 · 3 comments

Comments

@erikvold
Copy link
Contributor

This is basically the same issue as mozilla/prospector#9

@erikvold
Copy link
Contributor Author

@philikon can you review https://github.com/erikvold/BarTabLite/compare/issue-1 when you have a chance please? also please see #2 it is related.

@philikon
Copy link
Owner

I understand the problem now. I fail to remove the unloader for a particular window when the window is closed. Thanks for the pull request, will have a look.

@erikvold
Copy link
Contributor Author

Another technique you might be able to use to resolve this is to not use a unloader function. For example, if you had a window listener that added node X, then during shutdown you could enumerate through open windows and remove the node, thus no longer requiring a unloader at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants