Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support webkit #1

Open
ebidel opened this issue Mar 10, 2012 · 4 comments
Open

Support webkit #1

ebidel opened this issue Mar 10, 2012 · 4 comments

Comments

@ebidel
Copy link

ebidel commented Mar 10, 2012

Because this lib is awesome and should work everywhere possible :)

@paulirish
Copy link

I wonder if @jensarps idbwrapper is an appropriate dependency here

@philikon
Copy link
Owner

@paulirish link?

The only Gecko-specific APIs that I'm aware of is index.getAll(). This could easily be changed in my code, preferably using feature detection and a helper that will provide the same functionality in non-Gecko environments. Anyways, I'll happily accept patches. :)

@ebidel
Copy link
Author

ebidel commented Mar 12, 2012

IDBWrapper: https://github.com/jensarps/IDBWrapper

MDN has a nice example of implementing getAll(): https://developer.mozilla.org/en/IndexedDB/Using_IndexedDB#Using_a_cursor (2nd example in that cursor section).

@philikon
Copy link
Owner

Yep, faking/working around a missing getAll() isn't a problem. I just want to ensure we use the fast path in Gecko.

Thx for the link to idbwrapper. I'll take a closer look at it, but for me this is not an acceptable dependency, for various reasons, but in particular because we're planning on using queryIndexedDB in Gecko itself for dogfooding some of our own databases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants