Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend timestamp instead of appending #8

Open
spacemud opened this issue May 15, 2017 · 2 comments
Open

Prepend timestamp instead of appending #8

spacemud opened this issue May 15, 2017 · 2 comments

Comments

@spacemud
Copy link
Contributor

Are you getting sick of me yet? 馃槂

I noticed that with DailyLogger (and probably RotatingLogger too?) the files it creates have the timestamp appended to the end. This prevents users from specifying their own extension, like '.txt'. On Windows this makes it quite difficult to browse the log files - you also can't associate a program to open the log files due to the lack of an extension. A small convenience thing - but perhaps prepending the timestamp instead of appending it would allow a user to choose whatever extension they wanted.

@philip1337
Copy link
Owner

Hi,

nah, its okay 馃憤.

As example the daily logger uses a hardcoded filename calculation include/spdlog/sinks/file_sinks.h.

The same as here samp-plugin-spdlog/issues/5, I need to register own loggers wiki/2.-Creating-loggers to support that.

I will update the plugin and refactor some parts and then I will add an additional parameter for both functions to override the datetime formatting.

Kind regards
Sphinx

@spacemud
Copy link
Contributor Author

Ah - no worries then. I had a feeling that might be the case.

Thanks for your work on this plugin. Really useful stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants