Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofill notification disappears #19

Closed
jeroenev opened this issue Oct 3, 2017 · 5 comments
Closed

autofill notification disappears #19

jeroenev opened this issue Oct 3, 2017 · 5 comments
Milestone

Comments

@jeroenev
Copy link

jeroenev commented Oct 3, 2017

when i type a key on my keyboard (swiftkey in my example), regardless of key, including backspace and then slide down the notification tray with the autfill notification, it disappears, untill i leave the app and then open it again, then the autofill notification appears again

@PhilippC
Copy link
Owner

PhilippC commented Oct 3, 2017

can you create a logcat of this please?

@jeroenev
Copy link
Author

jeroenev commented Oct 3, 2017

logcat for KP2AAF: https://gist.github.com/jeroen7s/913e01e0463cdfdf587df9335a76073d
also been able to reproduce the other issue from notification tray.
the app i'm trying to login to is com.facebook.katana
it seems like it sometimes also detects com.touchtype.swiftkey
however what's more concerning is that it seems to detect:
com.snapchat.android
io.friendly
com.google.android.calendar
these apps weren't opened while i was logging, however, had notifications active in the notification tray.

@PhilippC
Copy link
Owner

PhilippC commented Oct 4, 2017

Thanks for the log! I don't really understand why these events pop up, but it's interesting that the root element's package name actually is com.android.systemui (can be seen from the URL=..):


[ 10-03 10:20:52.544  2949: 2949 D/KP2AAF   ] OnAccEvent
[ 10-03 10:20:52.544  2949: 2949 D/KP2AAF   ] event: 2048, package = com.google.android.calendar
[ 10-03 10:20:52.544  2949: 2949 D/KP2AAF   ] no com.android.systemui
[ 10-03 10:20:52.723  2949: 2949 D/KP2AAF   ] URL=androidapp://com.android.systemui
[ 10-03 10:20:52.725  2949: 2949 D/KP2AAF   ] Cancel notif

However, this seems to be different from the swiftkey events. From the logcat I don't see that these should cancel the notification:

[ 10-03 10:22:10.156 2949: 2949 D/KP2AAF ] OnAccEvent
[ 10-03 10:22:10.156 2949: 2949 D/KP2AAF ] event: 32, package = com.touchtype.swiftkey
[ 10-03 10:22:10.156 2949: 2949 D/KP2AAF ] no com.android.systemui
[ 10-03 10:22:10.254 2949: 2949 D/KP2AAF ] OnAccEvent

This means that the event is not discarded as a notification drawer event (which is correct), but it also neither cancels the notification (there is no Cancel Notif) nor does it update it in any way, so that looks ok. Maybe you can create a shorter log with only few accessibility events, focusing on the swiftkey issue?

@PhilippC PhilippC added this to the 1.02 milestone Oct 4, 2017
@PhilippC
Copy link
Owner

PhilippC commented Oct 5, 2017

@jeroen7s can you please check wtih the 1.02-pre4 which I uploaded to beta channel yesterday?

@jeroenev
Copy link
Author

jeroenev commented Oct 5, 2017

it does seem like the notification stays now, thanks a lot, i think the swiftkey issue must have been related, since that's also resolved (opening keyboard adds a notification to the notification tray, that's there to switch to different keyboards, that may have triggered the issue)

@jeroenev jeroenev changed the title autofill notification disappears after pressing key on swiftkey autofill notification disappears Oct 5, 2017
@PhilippC PhilippC closed this as completed Oct 9, 2017
PhilippC added a commit that referenced this issue Oct 20, 2017
….systemui),

also detect launcher from root.getPackageName(), see #19
support for Samsung Browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants