Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bors #44

Closed
wants to merge 3 commits into from
Closed

Add bors #44

wants to merge 3 commits into from

Conversation

matthiasbeyer
Copy link
Member

@matthiasbeyer matthiasbeyer commented Sep 11, 2022

This adds bors.


What you'd need to do: Go to https://bors.tech, add this repository (if you haven't done yet) and ensure the settings from this comment.

@matthiasbeyer
Copy link
Member Author

There might be still an issue with the worflow file, as actions should already be triggered by this PR.

@philippkeller
Copy link
Collaborator

@matthiasbeyer I just added bors through https://github.com/apps/bors/installations/new - is there something more I need to do?

@matthiasbeyer
Copy link
Member Author

Lets see whether bors knows of this repository... 😉

bors ping

@bors
Copy link
Contributor

bors bot commented Sep 11, 2022

pong

@matthiasbeyer
Copy link
Member Author

Nice. So yes, you'd need to ensure the settings I listed in this comment!

@philippkeller
Copy link
Collaborator

  • Disable squash merges (not required for bors per se, but anyways a good option) ✅
  • With "Require a pull request before merging" ✅
  • With "Require status checks to pass before merging" ✅
  • With "bors" as only required status check -> waiting until you configured bors
  • "Require pull request reviews before merging" MUST be unmarked -> didn't find this setting, is it called "Require review from Code Owners" ?
  • Required for administrators as well ✅

@matthiasbeyer
Copy link
Member Author

Awesome.

So lets see whether bors can merge this. I doubt it right now, as actions seems not to run yet. I had this problem before, and I know how to resolve it. Give me a few minutes!

bors merge

bors bot added a commit that referenced this pull request Sep 11, 2022
44: Add bors r=matthiasbeyer a=matthiasbeyer

This adds [bors](https://bors.tech).

What you'd need to do: Go to https://bors.tech, add this repository (if you haven't done yet) and ensure the settings from [this comment](#43 (comment)).

Co-authored-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@bors
Copy link
Contributor

bors bot commented Sep 11, 2022

Build succeeded:

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer deleted the add-bors branch September 11, 2022 11:26
@matthiasbeyer
Copy link
Member Author

I messed this up a bit. Bors already merged it.

@matthiasbeyer
Copy link
Member Author

"Require pull request reviews before merging" MUST be unmarked -> didn't find this setting, is it called "Require review from Code Owners" ?

Yes, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants