Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there public method for getting builder or json string? #74

Closed
fayvor opened this issue Jan 9, 2014 · 2 comments
Closed

Is there public method for getting builder or json string? #74

fayvor opened this issue Jan 9, 2014 · 2 comments
Assignees

Comments

@fayvor
Copy link
Contributor

fayvor commented Jan 9, 2014

Quick question: you use req._builder in SearchDslTest to get the json string from the query. I'd like to do this in my tests. Is there another way to get the json that doesn't use a private method?

https://github.com/sksamuel/elastic4s/blob/6d4b9e906880dc7b2c479d2a2e64ab61a133af7d/src/test/scala/com/sksamuel/elastic4s/SearchDslTest.scala

Thanks-
-f

@ghost ghost assigned sksamuel Jan 9, 2014
@sksamuel
Copy link
Collaborator

sksamuel commented Jan 9, 2014

We could make the builder public. Not reason why not, its immutable.

@sksamuel
Copy link
Collaborator

Do you want to submit a PR to make that field public?

sksamuel added a commit that referenced this issue Feb 13, 2014
@sksamuel sksamuel reopened this Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants