-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to add provenance for building docker images #73
Comments
some steps to retrieve the digest (only works after pushing the images to the registry
Now the provenance job can use this digest to filter the images based on digest. Unfortunately it is not possible to pull all tags by digest, so as a best effort so far I managed to pull all images from a repo and then inspect the digest.
|
See here the current progress of the feature |
Tried following API's to see if we can somehow fetch the related tags for a digest directly from the api
|
Unfortunately OCI has not released standard APIs for digests. Some registries have non standardised ones. Docker push cannot currently give you digests before pushing but other tools, eg Buildkit based tools can do this. We (Docker) are looking to make improvements in these areas, and would love feedback on our public roadmap https://github.com/docker/roadmap/issues about the areas we could help with. |
@justincormack thanks for clarifying. I am able to get the digest image tags, but only by first pulling all tags from a given repo.
The problem with that approach is that this will get slower and more resource intensive the more releases we make. See here the POC on trying to build this into this action. https://github.com/philips-labs/slsa-provenance-action/compare/container-provenance We are using a dedicated job with a clean runner to create provenance at this time, this is the reason why I need to pull the images. Some workarounds could be:
Really surprised none of the registries have the capability to fetch all tags for a given digest as this seems to be a very trivial thing that support dozen of use cases. Any thoughts on where to bring this up? Maybe this should become part of the OCI spec. |
When releasing docker images to various registries using various tags it would be good to be able to generate provenance using this action independent from the tooling/scripts that create the images and tags.
e.g.:
For each registry we would like to be able to generate provenance for the tags that are correlated to each other. We could leverage the docker image digest as a subject.
This provenance file could then be attached using cosign (sigstore) or notation (Notary Project).
In the current spec that would however be some duplication to express the same image using the various tags.
To be discussed:
The text was updated successfully, but these errors were encountered: