Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http proxy for talking to github URL #2231

Closed
dimitriosstander opened this issue Jul 8, 2022 · 3 comments
Closed

http proxy for talking to github URL #2231

dimitriosstander opened this issue Jul 8, 2022 · 3 comments

Comments

@dimitriosstander
Copy link

Hello,

I must use proxy for all outgoing communications - including talking to github.
in gh-auth.ts , I can add to ocktokitOptions something like:
auth: token, request: { agent: new HttpsProxyAgent('http://1.2.3.4.5:80'), },

But for createAppAuth that is not possible. I found octokit/auth-app.js#54 but I was unable to get it working. Any suggestions?

Thank you

@ScottGuymer
Copy link
Member

The good news is that this is already mostly implemented here

#1256

We have been struggling to add the required level of testing for it.

Maybe you could help us add that and we can get it merged?

@dimitriosstander
Copy link
Author

Hello,

I was only able to get

export async function createOctoClient(token: string, ghesApiUrl = ''): Promise<Octokit> {

working because they had the same issue at semantic-release/github#87. Rewriting the rest of the functions is beyond my current level. I roughly know what needs to be done since I used a similar process in a bash script: get an app private key, generate a token, use that token to register a runner. typescript and the likes I have never worked on before. I thought octokit/auth-app.js#54 would be a direct replacement, but that does not appear to be the case because of the various "Promise" entries.

So I would be able to submit some broken code, and hope that someone can fix it. At best.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants