feat: add retry logic to libicu download #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npalm - any chance we could get eyes on this? |
npalm
reviewed
Feb 8, 2024
@npalm - Anything you need from me for testing? |
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
npalm
approved these changes
Feb 12, 2024
npalm
pushed a commit
that referenced
this pull request
Feb 19, 2024
🤖 I have created a release *beep* *boop* --- ## [5.7.1](v5.7.0...v5.7.1) (2024-02-13) ### Bug Fixes * add retry logic to runner start script for libicu download ([#3748](#3748)) ([1b4597b](1b4597b)) * **lambda:** bump the aws group in /lambdas with 6 updates ([#3762](#3762)) ([e43fd80](e43fd80)) * **lambda:** bump the octokit group in /lambdas with 1 update ([#3763](#3763)) ([77586c5](77586c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
npalm
added a commit
that referenced
this pull request
Mar 14, 2024
…r dnf operations (#3787) ## Background --- This is a continuation of work done in #3748 There seems to be a race condition some where with the user-data script and the EC2 starting up and locking RPM. This issue is seen elsewhere, not necessarily with this repo's user-data, see the following: [Amazon Linux 2023 - issue with installing packages with cloud-init](https://repost.aws/questions/QU_tj7NQl6ReKoG53zzEqYOw/amazon-linux-2023-issue-with-installing-packages-with-cloud-init) [dnf/yum both fails while being executed on instance bootstrap on Amazon Linux 2023](https://repost.aws/questions/QUgNz4VGCFSC2TYekM-6GiDQ/dnf-yum-both-fails-while-being-executed-on-instance-bootstrap-on-amazon-linux-2023) Also, #3741 ## Changes Made --- Added a loop to retry if the rpm lock file is found which sleeps for 5 seconds then retries again with a total of 5 iterations. This logic is now added to the `user-data.sh` for the `upgrade-minimal` operation and installation of docker, cloudwatch-agent, and curl. ## Testing Done --- In progress. I'd like to open this up to review while testing. Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There seems to be a race condition some where with the user-data script and the EC2 starting up and locking RPM. This issue is seen elsewhere, not necessarily with this repo's user-data, see the following:
Amazon Linux 2023 - issue with installing packages with cloud-init
dnf/yum both fails while being executed on instance bootstrap on Amazon Linux 2023
Also, #3741
Changes Made
Added a loop to retry if the rpm lock file is found which sleeps for 5 seconds then retries again with a total of 5 iterations.
Testing
Spun up an instance and ran the script directly (using sudo the second time because this was not run via user-data)
