Lambda ami housekeeper and the ssm parameter store

[Lraharison]

The Lambda Ami housekeeper is currently encountering an issue where it ignores Parameter Store entries that do not contain "ami-id" in the AMI name. Consequently, it continues to delete the AMI referenced in the Parameter Store, even if it exceeds the ami_house_keeper_minimum_days_old threshold.

This is particularly evident in the code at line 194 [link to the code: [https://github.com/philips-labs/terraform-aws-github-runner/blob/main/lambdas/functions/ami-housekeeper/src/ami.ts#L194]].

[npalm]

Please can you provide some more details? The issue is not clear to me? Is the problem the string is hard coded?

[Lraharison]

Okay, when the value of the ssm_parameterNames parameter in the terraform ami-housekeeper module does not contain ami-id, the lambda ami housekeeper simply ignores it, so if the ami is older than the minimumDaysOld, it will be deleted. I hope I was clearer.

I'm not sure if the lambda code takes into account the value of this parameter or if it will just filter the SSM parameters containing ami-id in the name.

[npalm]

Thx for the feedback, In case you have some time feel free to suggest a change in a PR.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.