Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change log level for termination watcher if no match #3866

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

npalm
Copy link
Member

@npalm npalm commented Apr 25, 2024

Changed log level to debug in case no match. Deploying the lambda multiple times in a single aws account will create unrelated warning logs otherwise.

@npalm npalm requested a review from ScottGuymer April 25, 2024 06:38
Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@npalm npalm merged commit 649ad35 into main Apr 25, 2024
4 checks passed
@npalm npalm deleted the npalm/fix-log-termination-watcher branch April 25, 2024 06:49
npalm pushed a commit that referenced this pull request Apr 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.10.2](v5.10.1...v5.10.2)
(2024-04-25)


### Bug Fixes

* change log level for termination watcher if no match
([#3866](#3866))
([649ad35](649ad35))
* update dependencies
([#3867](#3867))
([85b5aac](85b5aac))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
npalm pushed a commit that referenced this pull request May 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.10.2](v5.10.1...v5.10.2)
(2024-04-25)


### Bug Fixes

* change log level for termination watcher if no match
([#3866](#3866))
([649ad35](649ad35))
* update dependencies
([#3867](#3867))
([85b5aac](85b5aac))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants