Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check for availability of __has_cpp_attribute #218

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Mar 1, 2023

Add a check if __has_cpp_attribute is available before using it; VS2017 does not seem to have this defined.

Closes #134

Our repository contains Dockefiles; make sure that they are kept up-to-date automatically.
Add a check if __has_cpp_attribute is available before using it; VS2017 does not seem to have this defined.

Closes #134
@rjaegers rjaegers requested a review from a team as a code owner March 1, 2023 10:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 10 0 0.04s
✅ DOCKERFILE hadolint 1 0 0.07s
✅ JSON eslint-plugin-jsonc 10 0 0 1.24s
✅ JSON prettier 10 0 0 0.69s
✅ JSON v8r 10 0 2.82s
⚠️ MARKDOWN markdownlint 6 0 9 0.57s
⚠️ MARKDOWN markdown-link-check 6 2 42.43s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.36s
✅ SPELL misspell 35 0 0 0.21s
✅ YAML prettier 18 1 0 1.1s
✅ YAML v8r 18 0 8.23s
✅ YAML yamllint 18 0 0.37s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rjaegers rjaegers added this pull request to the merge queue Mar 1, 2023
Merged via the queue into modern-cmake with commit 98b5c8d Mar 1, 2023
@rjaegers rjaegers deleted the feature/fix-has-cpp-attribute branch March 1, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS2017 does not implement __has_cpp_attribute
2 participants