Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical centering overflow #10

Closed
crsaracco opened this issue Sep 30, 2013 · 2 comments
Closed

Vertical centering overflow #10

crsaracco opened this issue Sep 30, 2013 · 2 comments

Comments

@crsaracco
Copy link

I'm not sure if it's just the way you wrote it or if it's a flexbox issue, but the vertical centering box will overflow the container box if it's too big (tested in firefox and chrome):

http://i.imgur.com/PP3HB1z.png

Again I didn't really look too far into it at all, I just tried this on the page and reported it, so sorry if this is by design.

@philipwalton
Copy link
Owner

Yeah, this used to not be a problem because I was using min-height instead of height in these examples, but then I discovered this IE bug where flexbox wasn't playing nice with min-height, so I converted the examples to use height as a compromise. But as you point out, it has this negative side effect.

I'll see if I can find a way to only use height for IE, which should fix this issue.

@philipwalton
Copy link
Owner

This should be fixed in b734f80. Let me know if you're still seeing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants