Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when lable is null #21

Closed
dodocat opened this issue Aug 2, 2014 · 1 comment
Closed

NPE when lable is null #21

dodocat opened this issue Aug 2, 2014 · 1 comment
Labels
bug confirmed bugs or otherwise incorrect behavior

Comments

@dodocat
Copy link
Contributor

dodocat commented Aug 2, 2014

stacktrace print

08-02 09:50:21.170  27172-27172/? E/AndroidRuntime﹕ FATAL EXCEPTION: main
    java.lang.NullPointerException
            at com.github.mikephil.charting.data.ChartData.alreadyCounted(ChartData.java:165)
            at com.github.mikephil.charting.data.ChartData.calcTypes(ChartData.java:124)
            at com.github.mikephil.charting.data.ChartData.init(ChartData.java:79)
            at com.github.mikephil.charting.data.ChartData.<init>(ChartData.java:43)
            at com.xxmassdeveloper.mpchartexample.fragments.SimpleFragment.getComplexity(SimpleFragment.java:85)
            at com.xxmassdeveloper.mpchartexample.fragments.LineChartFrag.onCreateView(LineChartFrag.java:53)
            at android.support.v4.app.Fragment.performCreateView(Fragment.java:1500)
            at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:938)
            at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1115)
            at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:682)
            at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1478)
            at android.support.v4.app.FragmentManagerImpl.executePendingTransactions(FragmentManager.java:478)
            at android.support.v4.app.FragmentPagerAdapter.finishUpdate(FragmentPagerAdapter.java:141)
            at android.support.v4.view.ViewPager.populate(ViewPager.java:1068)
            at android.support.v4.view.ViewPager.populate(ViewPager.java:914)
            at android.support.v4.view.ViewPager.onMeasure(ViewPager.java:1436)
            at android.view.View.measure(View.java:15551)
            at android.widget.RelativeLayout.measureChildHorizontal(RelativeLayout.java:681)
            at android.widget.RelativeLayout.onMeasure(RelativeLayout.java:461)
            at android.view.View.measure(View.java:15551)
            at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:4825)
            at android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
            at android.view.View.measure(View.java:15551)
            at android.widget.LinearLayout.measureVertical(LinearLayout.java:847)
            at android.widget.LinearLayout.onMeasure(LinearLayout.java:588)
            at android.view.View.measure(View.java:15551)
            at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:4825)
            at android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
            at com.android.internal.policy.impl.PhoneWindow$DecorView.onMeasure(PhoneWindow.java:2177)
            at android.view.View.measure(View.java:15551)
            at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:1887)
            at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:1102)
            at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1278)
            at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1002)
            at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:4400)
            at android.view.Choreographer$CallbackRecord.run(Choreographer.java:749)
            at android.view.Choreographer.doCallbacks(Choreographer.java:562)
            at android.view.Choreographer.doFrame(Choreographer.java:532)
            at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:735)
            at android.os.Handler.handleCallback(Handler.java:725)
            at android.os.Handler.dispatchMessage(Handler.java:92)
            at android.os.Looper.loop(Looper.java:137)
            at android.app.ActivityThread.main(ActivityThread.java:5041)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:511)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:817)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:584)
            at dalvik.system.NativeStart.main(Native Method)

in CharData.java

    private boolean alreadyCounted(ArrayList<String> countedLabels, String label) {
        for (int i = 0; i < countedLabels.size(); i++) {
            if (countedLabels.get(i).equals(label))
                return true;
        }

        return false;
    }
@PhilJay
Copy link
Owner

PhilJay commented Aug 2, 2014

Thank you for your input.

Because of your post I just realized that method is only part of a previous implementation and actually no longer needed (dead code).

I will completely remove this in the next commit.

Regards,
Phil

@PhilJay PhilJay closed this as completed Aug 2, 2014
@PhilJay PhilJay added the bug label Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bugs or otherwise incorrect behavior
Projects
None yet
Development

No branches or pull requests

2 participants