Xpack roles:elastic: Error 400 (Bad Request): request body is required [type=parse_exception]

[andrescolodrero]

Im having this error:
Error 400 (Bad Request): request body is required [type=parse_exception]

On a 7.5.0 Cluster,
with this configuration:

resource "elasticsearch_xpack_role" "kibana-admin" {
  role_name = "kibana-admin"
  indices {
    privileges = ["all"]
    field_security  = "*"
    names = ["*"]
  }

  applications {
      application = "kibana-.kibana"
      privileges = ["all"]
      resources = ["*"]

  }
  cluster = ["all"]
}

[phillbaker]

@andrescolodrero what version of the provider are you using?

[andrescolodrero]

@phillbaker sorry, i forget that detail.
im using latest, v0.10.0.

maybe the client for v7 will need an update?

[phillbaker]

It looks like there is an issue on 7.5: https://travis-ci.org/phillbaker/terraform-provider-elasticsearch/jobs/626767093#L1400. ESv7.4 and lower don't have issues.

Two potential PRs stand out from the release notes

• Validate index and cluster privilege names when creating a role elastic/elasticsearch#46361
• Validate query field when creating roles elastic/elasticsearch#46275

[phillbaker]

Looks like the tests pass on v7.5 after fixing some permissions that didn't exist, here's the commit: 5387064.

Is it possible that the values you used ended up creating invalid JSON when serialized? Did you get this error on a plan or apply? Can you try running the command again with TF_LOG=INFO and share the (redacted) output?

[andrescolodrero]

With same code as before, im getting a new type of error:

Error: Body Error :

on roles.tf line 48, in resource "elasticsearch_xpack_role" "arion-kibana-editor":
48: resource "elasticsearch_xpack_role" "arion-kibana-editor" {

i removed the line:
field_security = "*"

in code is "schema.TypeString",
but on my JSON test is:

        "field_security": {
          "except": [],
          "grant": [
            "*"
          ]   

[phillbaker]

Hm, I've been able to reproduce that: https://travis-ci.org/phillbaker/terraform-provider-elasticsearch/jobs/634034936#L1231. It comes from:

terraform-provider-elasticsearch/resource_elasticsearch_xpack_role.go

Lines 244 to 248 in 5387064

	body, err := json.Marshal(role)
	if err != nil {
	fmt.Printf("Body : %s", body)
	err = fmt.Errorf("Body Error : %s", body)
	}

So, the request isn't even being sent, seems like a bug in this provider. Thanks for the additional details.

[phillbaker]

@andrescolodrero an update on my side: fixing this will likely require changing the type of the field_security attribute. However, I did want to point out, that from the ES docs:

The absence of field_security in a role is equivalent to * access.

So there's no need to specify field_security": {"except": [],"grant": ["*"], that's the default.

[phillbaker]

I believe this was fixed as an outcome of #59. @andrescolodrero can you try v1.0.0 to see if that fixes the issue?

[phillbaker]

Going to close this for now, please re-open if this continues to be an issues.