Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: reformat Talon using talonfmt #36

Merged
merged 2 commits into from Sep 29, 2022
Merged

all: reformat Talon using talonfmt #36

merged 2 commits into from Sep 29, 2022

Conversation

phillco
Copy link
Owner

@phillco phillco commented Sep 15, 2022

Similar to talonhub/community#947, let's use talonfmt, although I prefer a slightly longer maximum line length.

Note that one change to notification.talon is working around a parser issue: wenkokke/talonfmt#17

@phillco phillco requested a review from pokey September 15, 2022 01:49
@phillco phillco changed the title all: reformat Talon using talonfmt all: reformat Talon using talonfmt Sep 15, 2022
window_doc.talon Outdated Show resolved Hide resolved
window_action.talon Outdated Show resolved Hide resolved
@wenkokke
Copy link
Contributor

Wouldn’t it make sense to match the line width, especially if this should eventually be upstreamed?

@phillco
Copy link
Owner Author

phillco commented Sep 15, 2022

I'd actually propose that we change the knausj width to 88 to match black, or even 100. I didn't realize how many rules would be split up onto multiple lines with a limit of 80, which I think makes them a bit more cumbersome to modify later. I'll raise that in knausj though.

@phillco phillco marked this pull request as draft September 15, 2022 16:19
Copy link
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just finished my knausj merge after talonfmt and it didn't do anything unexpected (aside from generating a parse error without a filename).

@phillco phillco marked this pull request as ready for review September 29, 2022 20:21
@phillco phillco merged commit b4a0020 into main Sep 29, 2022
@phillco phillco deleted the phil/2022-09-14/42r9 branch September 29, 2022 20:22
@wenkokke
Copy link
Contributor

Please use 1.8.0, which fixes the issues with negative numbers and private identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants