accessibility dictation: first round #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usj methods on failure
… the different element to serve as the input buffer
…ug_accessibility` setting
nriley
added a commit
to nriley/talon_community
that referenced
this pull request
Mar 20, 2022
nriley
added a commit
to nriley/talon_community
that referenced
this pull request
Mar 20, 2022
nriley
requested changes
Mar 20, 2022
nriley
reviewed
Mar 21, 2022
|
Thanks, made revisions |
|
Done |
nriley
requested changes
Mar 22, 2022
dictation/dictation_context.py
Outdated
|
|
||
| Sometimes the accessibility context reported by the application is wrong, but fixable in predictable ways (this is most common in Electron apps). This method can be overwritten in those applications to do so. | ||
|
|
||
| TODO(pcohen): it's a it strange to have both this and dictation_current_element; |
There was a problem hiding this comment.
Anything after a ":" gets stripped in actions.list() output (empirically) so consider moving into a comment.
dictation/electron.py
Outdated
|
|
||
| try: | ||
| app.element.AXManualAccessibility = True | ||
| except UIErr as e: |
There was a problem hiding this comment.
Can just use except UIErr: here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No rush on reviewing this! I figured it would be good to get your thoughts on this first batch of changes, before I go on to push more stuff. I'm probably going to focus on cursorless-on-JetBrains for the rest of the weekend so I'm not blocked on this review.
In this change:
My thought is the
experimentalbranch can be a sort of middle ground betweenmainand our feature branches. Ambitious beta testers could use it and it also gives us a place to merge our development changes together and test them together. We can promote it tomainafterwards.