Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to move forward with the python version #12

Closed
phillipberndt opened this issue Jan 16, 2015 · 5 comments
Closed

Decide how to move forward with the python version #12

phillipberndt opened this issue Jan 16, 2015 · 5 comments
Assignees

Comments

@phillipberndt
Copy link
Owner

There are currently two versions of autorandr around due to the difficulties with #7.

The Python version has some advantages over the bash version. That is naturally the case, because in Python we can pass around objects without having to serialize everything all the time. Unique features are solutions to #8, #9, reduced configurations that only store non-default settings with autorandr.py setting the values upon loading of the profiles, support for reflection & gamma values, and of course improved speed because it does not need to call awk, sed, md5sum and so on. I therefore won't just throw that code away.

On the other hand, the bash version obviously needs maintenance as well.

I'll have to decide whether to separate both versions into their own repositories, which one to promote to the version I primarily concerned myself with, and whether to choose a different name for the rewrite.

@bcremer
Copy link
Contributor

bcremer commented Jan 16, 2015

1+ for only maintaining one version.

I tend to favour the python version if it stays a single, self contained file.

I don't like to mess around with easy_install, pip or my distributions package manager to get this script running.

@phillipberndt
Copy link
Owner Author

I'm not a fan of superflous complexity, so yes, it will stay a single file. With your feedback, @tachylatus comment that he'd continue to contribute to a Python version in #8 and the momentum it gained with @RasmusWL's latest additions, I believe it's best to stick to the Python script.

Here's what I'm going to do, unless someone objects here:

  • Move the bash autorandr into a legacy branch in this repository (both aur and portage support branches, so packaging that version shouldn't be a problem) and update the pull-request in the upstream repository to pull from that branch accordingly
  • Adjust the Makefile to install autorandr.py as autorandr
  • But do not remove the extension from autorandr.py to allow easy merging/separation of the different versions and to alert maintainers to the change (for example, this ebuild will break).
  • Update the Readme, of course
  • I'll only write new code for the Python version
  • I'll continue to fix bugs as issue reports come in for the Bash version
  • I'll continue to pull merge requests for the legacy branch
  • If ever a incompatibility should be introduced, I'll add a warning to the bash version
  • If someone does not wish to go with the Python version and would maintain the Bash version himself, I'll replace the contents of the legacy branch with a message pointing to the new location / add a link to the master branch'es README on request, and will completely remove that branch after some time

@bcremer
Copy link
Contributor

bcremer commented Jan 25, 2015

Sounds all reasonable to me. +1

@phillipberndt
Copy link
Owner Author

Since no one complained, I went through with this.

@sparr
Copy link

sparr commented Jan 17, 2019

the bash version obviously needs maintenance as well.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants