Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectHasSelf should allow ObjectPropertyExpression #18

Closed
althonos opened this issue Jul 16, 2019 · 1 comment
Closed

ObjectHasSelf should allow ObjectPropertyExpression #18

althonos opened this issue Jul 16, 2019 · 1 comment

Comments

@althonos
Copy link
Collaborator

ObjectHasSelf is defined in the grammar:

ObjectHasSelf := 'ObjectHasSelf' '(' ObjectPropertyExpression ')'

but in the code it is only ObjectHasSelf(ObjectProperty).

(Also, it feels weird that this one is the only other tuple variant with Class while all the other are structs variants, it's not that elegant to mix both styles IMO).

@phillord
Copy link
Owner

Hopefully, I have fixed this now (the test for ObjectHasSelf was balked anyway, so have found out something useful). Will discuss the "also" in the other issue, since it's another issue:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants