Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS not HTTP when communicating with api.bit.ly #56

Closed
dmz006 opened this issue May 25, 2014 · 2 comments
Closed

Use HTTPS not HTTP when communicating with api.bit.ly #56

dmz006 opened this issue May 25, 2014 · 2 comments

Comments

@dmz006
Copy link

dmz006 commented May 25, 2014

While setting up the bitly gem I noticed that the API URL is set to:
API_URL = 'http://api.bit.ly/'

However when reviewing api.bitly.com, in their best practices I see their example of a valid API call to shorten the link uses:
https://api-ssl.bitly.com/

Is there any plan on updating this gem to use the https link so api keys aren't transmitted in cleartext?

@tompave
Copy link

tompave commented Aug 3, 2014

The SSL version is used in when connecting to the API v3:

https://github.com/philnash/bitly/blob/master/lib/bitly/v3/client.rb#L7

@philnash
Copy link
Owner

Well, this may have been a long time ago, but this has now been fixed in 301aa7a. Noone should be using the v2 API anyway, but if they do, next time I get a release out, it will use the https URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants