Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with assets generated by Jekyll-Assets #1

Closed
philnash opened this issue Jan 4, 2018 · 2 comments
Closed

Doesn't work with assets generated by Jekyll-Assets #1

philnash opened this issue Jan 4, 2018 · 2 comments

Comments

@philnash
Copy link
Owner

philnash commented Jan 4, 2018

When working on philna.sh I noticed that this successfully compresses HTML files, but the assets are generated by jekyll-assets (currently version 2.4, though this should be upgraded to version 3) and are not compressed.

Need to look at how Jekyll Assets handles the files and if this project can hook into the Jekyll Assets process to generate compressed files too.

@philnash
Copy link
Owner Author

Perhaps this shouldn't be the job of this gem. Assets that are looked after by an alternative gem should be compressed by that gem, or an extension to that gem, themselves.

Perhaps look into including gzip/zopfli/brotli compression in jekyll-assets first.

@philnash
Copy link
Owner Author

This now listens for the Jekyll::Assets hook and compresses everything in the output directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant