Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gzip/brotli compressed responses #16

Open
philnash opened this issue Mar 5, 2020 · 0 comments
Open

Support gzip/brotli compressed responses #16

philnash opened this issue Mar 5, 2020 · 0 comments
Assignees
@philnash

Comments

@philnash
Copy link
Owner

philnash commented Mar 5, 2020

The PwnedPasswords API will return gzipped or brotli encoded content if asked for it.

Currently the library will accept any headers passed through. If a user were to pass headers: { "Accept-Encoding" => "br" } the library would faithfully request the encoded response and then fail to do anything with it.

Thoughts:

  • No need to require any extra gems
    • can use Zlib to reflate gzip responses
    • if someone requests brotli, expect for them to have included a brotli supporting gem
@philnash philnash self-assigned this Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philnash philnash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philnash