Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up macro usage #19

Open
philpem opened this issue Aug 15, 2020 · 0 comments
Open

Clean up macro usage #19

philpem opened this issue Aug 15, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@philpem
Copy link
Owner

philpem commented Aug 15, 2020

Macros are used extensively within the code, especially in the emulator interface (memory access). The way they're used rarely follows best practice, looks messy, and confuses the way the code works. Furthermore, they're large and hard to follow.

At the very least the access-check functions should be reimplemented as static inline functions -- other macros should be reviewed.

@philpem philpem added enhancement New feature or request good first issue Good for newcomers labels Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant