Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like comments update may have changes #191

Closed
ldh68579 opened this issue Jul 4, 2017 · 1 comment
Closed

Looks like comments update may have changes #191

ldh68579 opened this issue Jul 4, 2017 · 1 comment

Comments

@ldh68579
Copy link

ldh68579 commented Jul 4, 2017

https://api.github.com/repos/jasongornall/always-green/issues/comments/312937694

octo.repos('philschatz', 'octokat.js').issues(1).comments(123123).update({body: 'Hello'}) appears to crash for me

info: error Error: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"} PATCH https://api.github.com/repos/jasongornall/always-green/issues/1/comments/312939953 Status: 404

octo.repos('philschatz', 'octokat.js').issues.comments(123123).update({body: 'Hello'}) works like a champ

info: Execution took 2627 ms, user function completed successfully
@philschatz
Copy link
Owner

Unfortunately, Octokat does not do a lot of runtime checking of URLs but it seems like you were able to get it working!

See #176 for static typechecking which would catch this error (if you use TypeScript).

Closing this Issue for now but please reopen if this is still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants