Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fast_html as an optional html parser #234

Closed
rinpatch opened this issue Nov 7, 2019 · 4 comments · Fixed by #240
Closed

Support fast_html as an optional html parser #234

rinpatch opened this issue Nov 7, 2019 · 4 comments · Fixed by #240
Labels

Comments

@rinpatch
Copy link

rinpatch commented Nov 7, 2019

Feature goal

fast_html is a C-Node binding for lexborisov's myhtml, it's from 1.2 to 2 times faster than html5ever (benchmark link) and requires only a c complier and gmake.

I can open a PR if you have no objection to adding it.

Dependencies

{:fast_html, "~> 0.99"}

:)

@chengyin
Copy link

chengyin commented Nov 14, 2019

mochiweb's lack of proper whitespace handling is a deal breaker for us.

html5ever's great on the correctness, and we are not that concerned with its performance. The problem is the elixir package, which is not maintained.

html5ever_rustler requires a rustler version update for each major Erlang/OTP release, otherwise build simply fails for the whole application. But the PR for upgrading hasn't received any feedback since August.

I've been searching for replacements and I'm excited for fast_html.

@rinpatch do you have any comments on the maintainance plan for fast_html going forward?

@philss
Copy link
Owner

philss commented Nov 14, 2019

@rinpatch I think this may be a great addition to the lib! Is it possible to do it by adding the fast_html dependency as optional?

@rinpatch
Copy link
Author

@rinpatch do you have any comments on the maintainance plan for fast_html going forward?

First of all, it's a pretty small library, so it doesn't take much effort to maintain. Second, it's used in Pleroma, which is an application deployed on 500 servers and fast_html parses thousands of html fragments there daily, so I am sure it's going to be maintained.

@rinpatch
Copy link
Author

@rinpatch I think this may be a great addition to the lib! Is it possible to do it by adding the fast_html dependency as optional?

I believe so, will try adding it on the weekend then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants