Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't it be agent.actor.forward() and calculate actor_loss? #8

Open
VijiKK opened this issue Jun 13, 2022 · 0 comments
Open

Shouldn't it be agent.actor.forward() and calculate actor_loss? #8

VijiKK opened this issue Jun 13, 2022 · 0 comments

Comments

@VijiKK
Copy link

VijiKK commented Jun 13, 2022

actor_loss = agent.critic.forward(states, mu).flatten()

Dear Phill,

First of all plenty of thanks and gratitude for your lessens, I've learned a lot from your lectures.
I've noticed a difference in the code at line 83 in MADDPG class while calculating actor-loss. It's running forward propagation of critic network instead of actor network. I believe this is typo, please correct me if I'm wrong.

Thanks and Regards
Viji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant