New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Demo App #21

Closed

andreasluca opened this issue Oct 17, 2018 · 1 comment

Contributor

andreasluca commented Oct 17, 2018

Hello,

As a proposal, I'd suggest the following:

Updating the Demo App to Swift 4.2
Resolving the warnings that appear in Xcode 10
To me it does not make a lot of sense the Demo App to have Pod dependencies when all the files are already in the repo. Wouldn't it be better to have the App compiling the local sources instead of having a pod dependency?

Thanks (it's just a suggestion)!

Owner

phimage commented Oct 20, 2018

Hello,
thanks for the suggestions
Do not hesitate to Pull Request if you have converted the demo app

For the demo app, podfile with " :path =>" is used for this purpose ie. development pod

phimage closed this as completed in

98d5278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment