Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3 support #16

Closed
mattahorton opened this issue Sep 15, 2016 · 14 comments
Closed

Swift 3 support #16

mattahorton opened this issue Sep 15, 2016 · 14 comments

Comments

@mattahorton
Copy link

Trying to compile my app with Swift 3 and I get two errors about unwrapping optionals. I've chosen to use the legacy swift compiler, but I think 2.3 (which is what I assume it's using) is also incompatible.

@mattahorton
Copy link
Author

I should say that it also breaks under 2.3 with 2 errors. UIImage? not unwrapped and CGContext? not unwrapped in LayoutEngine.swift

@phimage
Copy link
Owner

phimage commented Sep 15, 2016

Master branch is Swift 2.2 until xcode 8 release

Last updates on Swift 3 branch are for xcode beta
I have not yet open project with xcode gm, i will do it today

And create a Swift 2.3 branch also.

@mattahorton
Copy link
Author

Xcode 8 and Swift 3 released on the 13th.

@phimage
Copy link
Owner

phimage commented Sep 15, 2016

I know... but I cannot download xcode yet ;)
Then other dependencies are not up to date too and you can PR ;)

@matadan
Copy link
Contributor

matadan commented Sep 17, 2016

Maybe it would be possible to replace Eki with Async. That looks like the only dependency that is not being converted at the moment.

https://github.com/duemunk/Async

@phimage
Copy link
Owner

phimage commented Sep 17, 2016

Eki is already removed from swift 3.0 branch
https://github.com/phimage/Erik/blob/swift3.0/Podfile

BrightFutures 5.0.1 released this 13 hours ago
Kanna 2.0.0 is not released on cocoapod (just on github)

Maybe I will have time tomorrow

@matadan
Copy link
Contributor

matadan commented Sep 17, 2016

OK. I saw that after I posted. I have done some work here:

https://github.com/matadan/Erik

Do you want a Pull request?

@phimage
Copy link
Owner

phimage commented Sep 17, 2016

yes you can PR your swift3.0 branch into mine
(not the master one, with all carthage :o )

@matadan
Copy link
Contributor

matadan commented Sep 17, 2016

I think I have done that. It's my first PR.

@matadan
Copy link
Contributor

matadan commented Sep 18, 2016

I want to try building again today as I'm not convinced it converted everything to Swift 3.0 as expected.

@phimage
Copy link
Owner

phimage commented Sep 18, 2016

master branch is know swift3.0
all compile after an pod update
sources moved to Sources folder

no release into cocoapod (kanna is not released)

@e-zuka
Copy link

e-zuka commented Sep 21, 2016

sources moved to Sources folder

Then, why won't you update your podspec?

@phimage
Copy link
Owner

phimage commented Sep 21, 2016

395a19a

@phimage
Copy link
Owner

phimage commented Sep 22, 2016

2.0.0 tagged & pushed to cocoapod

maybe later

querySelector_ selector will become query(selector:
querySelectorAll(_ selector will become queryAll(selector:

@phimage phimage closed this as completed Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants