Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a passthru attribute to PHPStanTask so it can print errors #1767

Closed
tfedor opened this issue Nov 16, 2023 · 1 comment
Closed

Add a passthru attribute to PHPStanTask so it can print errors #1767

tfedor opened this issue Nov 16, 2023 · 1 comment
Milestone

Comments

@tfedor
Copy link

tfedor commented Nov 16, 2023

Describe the bug
With checkreturn argument it is possible for build to fail, but I can't seem to find an option to show errors. The actual command is run with 2>&1. Checking the code, it looks like in background ExecTask is being executed, which needs either output, error or passthru, but I can't find a way to pass it to the task.

Steps To Reproduce
Run PHPStanTask on a code that contains error.

Expected behavior
Errors should be printed to the console.

Additional context
3.0 RC6

@mrook
Copy link
Member

mrook commented Feb 11, 2024

Would you prefer capturing the output in a property, or just activating passthru?

@mrook mrook changed the title PHPStanTask does not print errors Add a passthru attribute to PHPStanTask so it can print errors Feb 21, 2024
@mrook mrook added this to the 3.0.0 milestone Feb 21, 2024
@mrook mrook closed this as completed in b882493 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants