Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[BUG][v1.3.1] plugins.txt gets cut off sometimes because not all files start with * #34

Closed
phinocio opened this issue Mar 1, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@phinocio
Copy link
Owner

phinocio commented Mar 1, 2021

Version Reported: v1.3.1

Initially Reported By: Gatonegro

Steps To Reproduce:

  • Upload a plugins.txt file that does not contain * at the beginning of each line

example

@phinocio phinocio added the bug Something isn't working label Mar 1, 2021
@phinocio phinocio self-assigned this Mar 1, 2021
@phinocio
Copy link
Owner Author

phinocio commented Mar 1, 2021

This is due to me simply doing

if ($fileName == "plugins.txt") {
	$line = substr($line, 1);
}

to remove the * from the beginning of the line due to my test file having it for every line.

Likely solution is to do a check to see if the line starts with * and remove it only if it does (or simply do a str_replace for it).

@phinocio
Copy link
Owner Author

phinocio commented Mar 2, 2021

Fixed with v1.3.2

@phinocio phinocio closed this as completed Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant