Remove execute bit from bin/brew-cask.rb #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecuted by the shell
|
This is a workaround for #3624 as suggested by @ianheggie. |
|
Commented in more detail over on the other thread, but +1 for this. Pulling it in. |
phinze
added a commit
that referenced
this pull request
Mar 24, 2014
Remove execute bit from bin/brew-cask.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/brew-cask.rb is meant to be required by Homebrew, not actually executed by
the shell. The execute bit is causing rbenv-binstubs to pick up
bin/brew-cask.rb is an executable and is shimming it. Which then causes
Homebrew to attempt to
requirethe rbenv-shimmed shell script rather than theruby script.
IMO, the correct behavior is for non-executable ruby scripts to never be
placed in bin/ in the first place. But as Homebrew requires this behavior for
its external commands, removing the execute bit is a workaround.