Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] ttfb doesnt allow https://1.1.1.1/cdn-cgi/trace #6

Closed
12932 opened this issue Mar 22, 2022 · 2 comments · Fixed by #7
Closed

[Bug] ttfb doesnt allow https://1.1.1.1/cdn-cgi/trace #6

12932 opened this issue Mar 22, 2022 · 2 comments · Fixed by #7
Assignees
@phip1611
Labels
bug Something isn't working

Comments

@12932
Copy link

12932 commented Mar 22, 2022 

ttfb -k "https://1.1.1.1/cdn-cgi/trace"
Invalid URL! https can only be used when a domain name is given. IP addresses don't work.

This isn't true, any valid SSL cert that contains IP addresses in the Subject Alternative Name fields are considered secure (see image and website https://1.1.1.1 as an example as to why this isn't true)

image
@phip1611
Copy link
Owner

Hey @12932
Good catch! Thanks! I'll look into it later.

@phip1611 phip1611 self-assigned this Mar 22, 2022
@phip1611 phip1611 added the bug Something isn't working label Mar 22, 2022
@phip1611 phip1611 linked a pull request Mar 22, 2022 that will close this issue
latest dev branch (v1.3.1) #7
Merged
@phip1611
Copy link
Owner

Fixed and released on crates.io :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phip1611 phip1611

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

latest dev branch (v1.3.1) phip1611/ttfb
2 participants
@phip1611 @12932