Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker files do not work #9

Open
Te-k opened this issue Oct 1, 2020 · 1 comment
Open

Docker files do not work #9

Te-k opened this issue Oct 1, 2020 · 1 comment

Comments

@Te-k
Copy link

Te-k commented Oct 1, 2020

The docker files do not work for two reasons:

  • The install is not done just with make
  • phishdetect needs libyara4 that is not in buster, the debian version used with the golang docker image

First one can be fixed with:

--- a/Dockerfile
+++ b/Dockerfile
@@ -1,11 +1,10 @@
-FROM golang:1.13
+FROM golang:latest
 
 WORKDIR /go/src/app
 COPY . .
 
 RUN apt-get update -y && apt-get install -y libyara-dev pkg-config
 
-RUN make deps
-RUN make linux
+RUN make
 
 ENTRYPOINT ./build/linux/phishdetect-node --host 0.0.0.0

The second issue needs more work, I think it would requires to use a debian testing image and install go manually.

No urgent fix, just adding a note here if it needs to be done later on.

@botherder
Copy link
Contributor

Can't yara be compiled manually as done here? https://github.com/phishdetect/phishdetect-node/blob/master/.travis.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants