Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling with newly built story format throws TypeError on marked dependency #37

Closed
phivk opened this issue Jun 30, 2022 · 0 comments · Fixed by #38
Closed

Compiling with newly built story format throws TypeError on marked dependency #37

phivk opened this issue Jun 30, 2022 · 0 comments · Fixed by #38
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@phivk
Copy link
Owner

phivk commented Jun 30, 2022

How to reproduce

Install dependencies

npm install

build story format

grunt package

(optionally depending on your setup: move built format to Tweego storyformats directory)

compile .twee to .html

tweego --output=./docs/trialogue-demo-test.html ./docs/trialogue-demo.twee  --format=Trialogue

open restulting .html file

open ./docs/trialogue-demo-test.html

result:

⚠ TypeError: marked is not a function 

0D72222A-7352-4690-919B-BD8D06FD446D-54098-0000FF91879925DA

Things I've tried so far

  • removing node_modules/ and package-lock.json and doing a fresh npm install
  • checking out a prior state of the repo from the git history
  • making a fresh clone of the repo
  • importing marked into the browser by adding a script tag to the restuling .html file: <script src="https://cdn.jsdelivr.net/npm/marked/marked.min.js"></script>

I am unsure why this was not an issue before or what has changed that introduced this error.

Curious if others can reproduce this issue?

@phivk phivk added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jun 30, 2022
@phivk phivk closed this as completed in #38 Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant