-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to documentation that adjust_text() needs to be called last! #40
Comments
Hi, thank you for your comments - you are absolutely right, the documentation is currently basically non-existent, but I don't think I currently have time to develop it properly... I would be happy merge PRs that would address this in any way! I'll try to specifically add the points you are raising here. I thought the last point should be quite obvious (of course we can't adjust positions of texts if the axes are not set up properly, and we don't know their future limits!), but you are not the first person to mention this, so I guess you are right and this should be written explicitly. |
Please see whether the newly added wiki addresses your concerns, and feel free to improve it! |
@Phlya Thank you for your enthousiasm and for putting something on the wiki this fast :-) This addresses points 2 and 3 but not point 1. I will try to do a PR in the upcoming days for the readme, but already the wiki will surely help :-) |
You are right of course, the docstring should be converted to numpydoc format too... Thank you for the ideas again, and hope to see your PR soon then :) |
I think it's sufficiently clear now. |
Hey there,
It's a very very useful library, but I banged my head so many times trying to use it that I find I unfortunate that it could have saved so many hours if the documentation was a bit more guiding, and I guess most users either lost a lot of time like me or just dropped the library in frustration.
I feel the documentation should be updated to at least include:
texts
, and calladjust_text(texts)
just beforeplt.show()
.I think this last note is the most important of all additions to the readme, as calling adjust_text() anytime before is bound to produce undefined behavior, which is not specified in a clear manner anywhere.
Indeed, even if one calls
adjust_text()
only on a subset of text objects, it will still produce erratic behavior, like text moved far away from points (I could not pinpoint the root cause), or outside the boundary of the image (the latter only if the image gets resized afterward).The text was updated successfully, but these errors were encountered: