Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App/Bookmark/Search] Open links in new tabs, make apps and bookmarks searchable #10

Open
DeRuiterIndustrieleAutomatisering opened this issue Mar 19, 2021 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@DeRuiterIndustrieleAutomatisering

What do I have to change to open all (apps and bookmarks) links in new tabs? (I'm just started learning React)

Can you add a button to erase the previous search statement with one click?

Do you like the idea to update the lists when typing a search statement and only show applications and bookmarks which are equal to the search?

@phntxx
Copy link
Owner

phntxx commented Mar 19, 2021

Hi!

I'll go through your questions 1 by 1:

What do I have to change to open all (apps and bookmarks) links in new tabs?

  1. This line in app.tsx would have to look like this: <AppLink href={URL} target="_blank">{name}</AppLink>
  2. This line in bookmarkGroup.tsx would have to look like this: <Bookmark key={[name, idx].join("")} href={url} target="_blank">
  3. This line in imprint.tsx would have to look like this: <Link href={field.link} target="_blank">{field.text}</Link>
  4. Bookmarks are handled through window.location.href-calls, as far as I know you can't reliably change that in a way that it opens a new tab

Can you add a button to erase the previous search statement with one click?

That sounds like a good idea that should be easy to implement. I'll add that once I get around to it.

Do you like the idea to update the lists when typing a search statement and only show applications and bookmarks which are equal to the search?

While I do like the idea, I can't tell how hard that would be to implement. I'll have a look at it.

Thank you very much for your input! :)

Kind regards
Bastian

@phntxx
Copy link
Owner

phntxx commented Mar 21, 2021

Quick Update: I've added that button to erase the search statement with one click (I made it so that it appears if there's something search bar)

@phntxx phntxx added the enhancement New feature or request label Apr 23, 2021
@phntxx phntxx changed the title Improvements? [App/Bookmark/Search] Open links in new tabs, make apps and bookmarks searchable Apr 23, 2021
@phntxx phntxx added this to No Status in Ideas Apr 23, 2021
@phntxx phntxx moved this from No Status to Completed in Ideas Aug 2, 2021
@phntxx phntxx moved this from Completed to No Status in Ideas Aug 2, 2021
@KillerTic
Copy link

Could there be an option to have the search open a new tab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Ideas
No Status
Development

No branches or pull requests

3 participants