Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

[FeatureRequest] Improve Pull Request Template #18

Closed
mibaumgartner opened this issue Dec 13, 2019 · 2 comments · Fixed by #26
Closed

[FeatureRequest] Improve Pull Request Template #18

mibaumgartner opened this issue Dec 13, 2019 · 2 comments · Fixed by #26
Labels
FeatureRequest Request for additional feature

Comments

@mibaumgartner
Copy link
Member

Description
This issue is intended to provide a forum to improve our PR template

Proposals

Additional todos:

  • update codeowners.md
  • update changelog

Furthermore, I would like to propose to structure the todos a little bit more. Something like:
Developer (the person who implements the PR), RisingMember (someone who has rights to add lables, projects, modify codeowner , chagelog ... )

We could also introduce a reviewer section where we add some points which every reviewer should check (probably with an link to our contribution guideline)

Do you have additional points or do not like any of the above? @haarburger @justusschock

@mibaumgartner mibaumgartner added the FeatureRequest Request for additional feature label Dec 13, 2019
@mibaumgartner mibaumgartner added this to TODO Next Release in Orga via automation Dec 13, 2019
@mibaumgartner mibaumgartner changed the title [FeatureRequest] Improves Pull Request Template [FeatureRequest] Improve Pull Request Template Dec 13, 2019
@haarburger
Copy link
Contributor

I tend to appreciate your suggestions. On the other side, if the whole project is too organised formally, it might appear intimidating to potential contributors..

@mibaumgartner
Copy link
Member Author

mibaumgartner commented Dec 14, 2019

Yes, that may be a risk. On the other hand, I do not think it is beneficial to hide the process which every pr should go through anyway. When splitting the tasks we could use collapsible sections to hide the RisingMember and Reviewer tasks which would be less intimidating.

https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab

@mibaumgartner mibaumgartner mentioned this issue Dec 22, 2019
9 tasks
@mibaumgartner mibaumgartner moved this from To do to In progress in Orga Dec 22, 2019
Orga automation moved this from In progress to Done Jan 2, 2020
@mibaumgartner mibaumgartner removed this from Done in Orga Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest Request for additional feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants