Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phx.gen.cert cannot generate a certificate on 2024-02-29 with a valid end date #5737

Closed
quitejonny opened this issue Feb 29, 2024 · 1 comment

Comments

@quitejonny
Copy link
Contributor

quitejonny commented Feb 29, 2024

Environment

  • Elixir version: 1.15.7
  • Phoenix version (mix deps): 1.7.10
  • Operating system: Ubuntu 22.04

Actual behavior

The task phx.gen.cert could not generate a certificate on 2024-02-29 with a valid end date.
It would try to use 2025-02-29 as the end date.
Today (2024-02-29) the phoenix tests (test/mix/tasks/phx.gen.cert_test.exs) are failing.

Expected behavior

You can generate a certificate with valid end date on 2028-02-29.

I provided a fix #5736

@chrismccord
Copy link
Member

❤️❤️❤️🐥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants