Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using mix phx.new with --no-html still configures live_view in test config #5790

Closed
pcapel opened this issue Apr 22, 2024 · 2 comments · Fixed by #5802
Closed

Using mix phx.new with --no-html still configures live_view in test config #5790

pcapel opened this issue Apr 22, 2024 · 2 comments · Fixed by #5802

Comments

@pcapel
Copy link
Contributor

pcapel commented Apr 22, 2024

Environment

  • Elixir version (elixir -v):
    Erlang/OTP 26 [erts-14.0] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]

    Elixir 1.16.0 (compiled with Erlang/OTP 26)

  • Phoenix version (mix deps):
    {:phoenix, "~> 1.7.12"}

  • Operating system:
    MacOS Sanoma 14.4.1

Actual behavior

Running mix test fails because config/test.exs contains a configuration for :phoenix_live_view which isn't installed under the --no-html flag. The offending block is:

config :phoenix_live_view,
  # Enable helpful, but potentially expensive runtime checks
  enable_expensive_runtime_checks: true

Expected behavior

Running mix test passes all pre-configured tests immediately after project generation.

@josevalim
Copy link
Member

Good find, please do send a PR!

@pcapel
Copy link
Contributor Author

pcapel commented May 6, 2024

Okidoki! #5802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants