Dashes as URL separator

[pma]

The implementation of Phoenix.Router.Path.split will not allow using dashes in the value of a named parameter.

For example, this route:

get "/resource/:id", App.Controllers.Resource, :show

will not match http://localhost:4000/resource/75f6306d-a090-46f9-8b80-80fd57ec9a41

But if we define a route that will match http://localhost:4000/resource?id=75f6306d-a090-46f9-8b80-80fd57ec9a41

we'll have the UUID with dashes included available in conn.params["id"]

Maybe I'm missing something, but I think the two cases above should yield similar results and dashes should not be considered a URL separator in the split function.

[chrismccord]

This is fixed on master. The caveat is routes such as get "users/profile-:id" are no longer supported after this change. We can support both cases by generating an additional match definition, but for now I'd like to support your use-case which is much more prevalent.