Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max carrier size column behaviour #415

Closed
alexcastano opened this issue Apr 22, 2023 · 1 comment · Fixed by #416
Closed

Max carrier size column behaviour #415

alexcastano opened this issue Apr 22, 2023 · 1 comment · Fixed by #416

Comments

@alexcastano
Copy link
Member

In the new "Memory Allocator" page we have the column Max carrier size. We use the max value returned by the BEAM.

image

However, the :observer.start() set the max value since the page is shown (or since the observer started), not from the start of the BEAM. I think we can reproduce the same behaviour by keeping a list of the max value per row, in a similar way we do to calculate the reductions:

def fetch_processes(node, search, sort_by, sort_dir, limit, prev_reductions \\ nil) do
search = search && String.downcase(search)
:rpc.call(node, __MODULE__, :processes_callback, [
search,
sort_by,
sort_dir,
limit,
prev_reductions
])
end

The question is, do we want that behavior? Or do we want an extra column?

@josevalim
Copy link
Member

I think following observer is the saner choice as they probably thought more and have more context than us. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants