-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Reloading Broken in Windows 10 #62
Comments
Please include your version of |
Also, is anything logged when you run |
On changing files it is not logging anything to 'iex' on phoenix 1.3 but on phoenix 1.2 it shows log. |
@superherointj just to be double sure, can you please start a new phoenix session with |
As a data point, a Phoenix 1.3 project on Windows 10 in |
D:\dev\elixir\liver>iex -S mix phx.server HERE I OPEN THE PAGEiex(1)> [info] GET / HERE I CHANGE ONE FILE FOR EXAMPLE APP.JS added a console.log('changed') to itiex(1)> 14:49:39 - info: compiled app.js and 3 cached files into app.js in 115 ms There is no additional logs!!See picture: |
Thanks @OvermindDL1! Can you please check it after |
@superherointj thanks! We can see that the assets are being recompiled. So it is indeed something specific to the live reload in particular. |
D:\dev\elixir\liver>mix deps.update phoenix_live_reload |
Sorry, the @superherointj, can you please try this:
And let us know what it returns? |
What should I fill Path.absname("") with? Try it empty? -- HERE I LOAD PAGEiex(2)> [info] GET / HERE I MAKE CHANGE TO app.jsiex(2)> 15:08:48 - info: compiled app.js and 3 cached files into app.js in 93 ms No logs about change event on iex. No automatic update on browser. |
@superherointj helped me find the bug. The issue is that the paths reported by @falood @mveytsman what do you think should be the proper solution here? Should the filesystem project normalize paths? Or should it return the raw paths and Phoenix does the normalization? In any case, the solution is easy:
It is just a matter of deciding the best place to put it. |
@falood yes, that's why using But if you don't think we should change file_system, then I can fix it here. :) your call! |
sure, I'll fix it and bump a new version today, thank you! |
@josevalim I have fixed and released the new version, it's not a fast-forward change, so the new version number is |
Beautiful, thank you! @superherointj can you please run:
and let us know if it works? Thank you. |
file_system 0.2.0; phoenix_live_reload 1.1.0 |
❤️ 💚 💙 💛 💜 |
Since latest changes live reloading is not working in Windows 10.
Phoenix 1.2 worked.
Phoenix 1.3 doesn't.
Tested by two different users.
I was asked to post here instead of Phoenix tracker.
I don't know how to dig further the issue.
Erlang/OTP 20 [erts-9.0] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:10]
Elixir 1.5.1
The text was updated successfully, but these errors were encountered: