Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialyzer issues being caused in main phoenix repo #115

Closed
jeremyowensboggs opened this issue Sep 13, 2018 · 0 comments · Fixed by #116
Closed

Dialyzer issues being caused in main phoenix repo #115

jeremyowensboggs opened this issue Sep 13, 2018 · 0 comments · Fixed by #116

Comments

@jeremyowensboggs
Copy link

With regards to phoenixframework/phoenix#3027
I have tracked it down to shard.ex

@spec list(pid, topic) :: [presence]
  def list(server_pid, topic) do
    server_pid
    |> GenServer.call({:list, topic})
    |> State.get_by_topic(topic)
  end

The spec needs to be updated to @spec list(pid | atom, topic) :: [presence]
In addition, there are several other dialzyer issues in the shard.ex file I have fixes for.

I notice that the dialyzer package is no longer supported, could I also switch to the recommended https://github.com/Comcast/dialyzex or https://github.com/jeremyjh/dialyxir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant